Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some small stuff found with Valgrind #2854

Merged
merged 3 commits into from
Aug 15, 2015
Merged

Fix some small stuff found with Valgrind #2854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b73a9e
PulseAudio: fix small memleak
Tilka Aug 15, 2015
b3ff66d
evdev: don't pass null path to the kernel
Tilka Aug 15, 2015
b0cc026
CachedInterpreter: avoid uninitialized value
Tilka Aug 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/Core/AudioCommon/PulseAudioStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ void PulseAudio::StateCallback(pa_context* c)
void PulseAudio::UnderflowCallback(pa_stream* s)
{
m_pa_ba.tlength += BUFFER_SAMPLES * m_channels * m_bytespersample;
pa_stream_set_buffer_attr(s, &m_pa_ba, nullptr, nullptr);
pa_operation* op = pa_stream_set_buffer_attr(s, &m_pa_ba, nullptr, nullptr);
pa_operation_unref(op);

WARN_LOG(AUDIO, "pulseaudio underflow, new latency: %d bytes", m_pa_ba.tlength);
}
Expand Down
2 changes: 2 additions & 0 deletions Source/Core/Core/PowerPC/CachedInterpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ void CachedInterpreter::Init()
{
m_code.reserve(CODE_SIZE / sizeof(Instruction));

jo.enableBlocklink = false;

JitBaseBlockCache::Init();

code_block.m_stats = &js.st;
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/InputCommon/ControllerInterface/evdev/evdev.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ void Init(std::vector<Core::Device*> &controllerDevices)

const char* devnode = udev_device_get_devnode(dev);
// We only care about devices which we have read/write access to.
if (access(devnode, W_OK) == 0)
if (devnode && access(devnode, W_OK) == 0)
{
// Unfortunately udev gives us no way to filter out the non event device interfaces.
// So we open it and see if it works with evdev ioctls or not.
Expand Down