DSP HLE: Remove timing informations from ucodes #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I wish AX didn't rely on this update interval at all, to be fair :) |
| @@ -671,17 +671,13 @@ void AXUCode::Update() | |||
| } | |||
| else if (m_work_available) | |||
| { | |||
| m_work_available = false; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Fixes the missing FMV audio in AX-Wii games, Little King's Story, The Last Story, Donkey Kong Country Returns. Fixes slow audio in many 48K games, including a bunch of random sports games I can't be bothered to type, Dave Mirra's Freestyle BMX 2 and some more sports games. |
It was done on Update() which was called exactly every 5ms. But the game is allowed to use the DSP more often, eg to generate 48kHz audio.
On HLE, we don't emulate the timings on HLE, so there is also no need to setup periods callbacks.
|
Retested, LGTM |
degasus
added a commit
that referenced
this pull request
Aug 19, 2015
DSP HLE: Remove timing informations from ucodes
mimimi085181
added a commit
to mimimi085181/dolphin
that referenced
this pull request
Apr 24, 2016
…verts commit: 896a02b. Hopefully sound still works properly with this for games that use 48 kHz audio on AX ucodes and it fixes sound for Neo Geo games, see issue: https://bugs.dolphin-emu.org/issues/9315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On HLE, we don't emulate the timings on HLE, so there is also no need
to setup periods callbacks.
This fixes AX HLE when used for 48 kHz audio.