Cleanup and unify efb copy implemtations into VideoCommon #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phire
force-pushed
the
unify_efbcopy
branch
2 times, most recently
from
56a6b4d
to
c25e2db
Compare
| } | ||
|
|
||
| // Fill gamecube memory with the tag value | ||
| void TextureCache::TCacheEntryBase::Memset(u8* ptr, u32 tag) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Addded a few duplicated depth copy texture formats to the enum in TextureDecoder.h. These texture formats were already implemented in TextureCacheBase and the ogl/dx11 texture cache implementations.
Fixes purple shadow in THPS4 and many other things.
|
LGTM, nice cleanup |
phire
added a commit
that referenced
this pull request
Sep 6, 2015
Cleanup and unify efb copy implemtations into VideoCommon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.