Fix deadlock with KHR_debug. #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An KHR_debug callback could end up waiting for a mutex on a thread which calls windows system functions. While this is not expressly forbidden by the standards, it does forbid directy calling windows system functions from a KHR_debug callback. Close enough.
|
LGTM |
phire
added a commit
to phire/dolphin
that referenced
this pull request
Oct 7, 2015
After fixing the deadlock in dolphin-emu#3006, it is now possible for log messages to flood in faster than UpdateLog can render them. This causes it to never return, locking up the gui thread and filling the windows message queue (which triggers the stack overflow bug in older versions of Wx)
phire
added a commit
to phire/dolphin
that referenced
this pull request
Oct 8, 2015
After fixing the deadlock in dolphin-emu#3006, it is now possible for log messages to flood in faster than UpdateLog can render them. This causes it to never return, locking up the gui thread and filling the windows message queue (which triggers the stack overflow bug in older versions of Wx)
phire
added a commit
to phire/dolphin
that referenced
this pull request
Oct 8, 2015
After fixing the deadlock in dolphin-emu#3006, it is now possible for log messages to flood in faster than UpdateLog can render them. This causes it to never return, locking up the gui thread and filling the windows message queue (which triggers the stack overflow bug in older versions of Wx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An KHR_debug callback could end up waiting for a mutex on a thread which calls windows system functions.
While this is not expressly forbidden by the standards, it does forbid directly calling windows system functions from a KHR_debug callback. Close enough.