Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some logging for depth tested efb color pokes. #3009

Merged
merged 1 commit into from Sep 12, 2015

Conversation

phire
Copy link
Member

@phire phire commented Sep 9, 2015

No description provided.

if (addr & 0x00800000)
{
// It's possible to do a z-tested write to efb by writing a 64bit value to this address range.
// Not much is known, but lets at least get some loging.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@neobrain
Copy link
Member

neobrain commented Sep 9, 2015

Do we know anything which uses this feature, yet, even if it's just a pathological test case?

@phire
Copy link
Member Author

phire commented Sep 10, 2015

Game Boy Interface (homebrew gameboy player interface software) apparently uses a lot of features dolphin doesn't support, including depth tested pokes.

It's possible one or two games use it, I was considering using a panic alert instead of a error log so we would get a bug report faster if something was using it.

phire added a commit that referenced this pull request Sep 12, 2015
Add some logging for depth tested efb color pokes.
@phire phire merged commit c0a89c3 into dolphin-emu:master Sep 12, 2015
@phire phire deleted the depth_tested_pokes branch September 12, 2015 10:21
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants