Removed fastmem from Android UI #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt this is enough. Can you search for "fastmemPref" in the Android directory? |
|
Oh, do I need to remove the other references to fastmem in the Userpreferences.java file? I still want it to pick up whatever the user changes in the ini and my shield is refusing to write dolphin's config files to storage for some stupid reason so I literally can't test this. |
|
Reading the ini is done in core, so you can remove fastmem everywhere android specific. |
Helios747
force-pushed
the
Security101
branch
from
34525c4
to
d8b98b2
Compare
| @@ -133,8 +132,6 @@ public static void SavePrefsToIni(Context ctx) | |||
| { | |||
| SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(ctx); | |||
|
|
|||
| // Whether or not the user is using dual core. | |||
| boolean isUsingDualCore = prefs.getBoolean("dualCorePref", true); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Helios747
force-pushed
the
Security101
branch
from
d8b98b2
to
3c115dd
Compare
Helios747
force-pushed
the
Security101
branch
from
3c115dd
to
cbd7b07
Compare
|
LGTM |
Sonicadvance1
added a commit
that referenced
this pull request
Sep 11, 2015
Removed fastmem from Android UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Sonicadvance1 recommended this.