Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemTimers: Don't name non-constant variables as if they are constant #3084

Merged
merged 1 commit into from Sep 27, 2015

Conversation

JosJuice
Copy link
Member

No description provided.

static int s_audio_dma_period;
// This is completely arbitrary. If we find that we need lower latency,
// we can just increase this number.
static int s_ipc_hle_period;

This comment was marked as off-topic.

This comment was marked as off-topic.

@degasus
Copy link
Member

degasus commented Sep 23, 2015

LGTM

@JosJuice JosJuice changed the title CoreTiming: Don't name non-constant variables as if they are constant SystemTimers: Don't name non-constant variables as if they are constant Sep 24, 2015
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • fortune-street-white-box on ogl-lin-mesa: diff
  • chibi-robo-fastdepth on ogl-lin-nv: diff
  • mini-ninjas on ogl-lin-nv: diff
  • my-word-coach on ogl-lin-nv: diff
  • nfsu-reflections on ogl-lin-nv: diff
  • tos-invis-char on ogl-lin-nv: diff

automated-fifoci-reporter

@waddlesplash
Copy link
Contributor

LGTM

phire added a commit that referenced this pull request Sep 27, 2015
SystemTimers: Don't name non-constant variables as if they are constant
@phire phire merged commit 4817118 into dolphin-emu:master Sep 27, 2015
@JosJuice JosJuice deleted the cpu-core-clock branch September 27, 2015 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants