Do not try to load strided efb copies or ones with wrong dimensions #3165
Conversation
This hopefully allows to use partial texture updates with strided efb copies that start at the same offset as the loaded texture
mimimi085181
force-pushed
the
partial-texture-updates-same-offset
branch
from
96e7aa8
to
af28934
Compare
mimimi085181
changed the title
mimimi085181
changed the title
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
LGTM |
|
What issue does this fix in Mario Kart Wii? Would it be the lens flare effect with "EFB Copies to Texture Only"? |
|
Sorry no, it's should be this issue: https://bugs.dolphin-emu.org/issues/9027 |
…me-offset Do not try to load strided efb copies or ones with wrong dimensions
|
Español Hola, desde esta compilacion detecte un error en Donkey Kong Country Returns, el personaje de donkey kong desaparece y aparece a cada rato, al desactivar "Copia de EFB a escala" vuelve a funcionar sin problemas, pero con menor calidad en las texturas del donkey kong, la compilacion dolphin-master-4.0-8008 funciona bien en comparacion con esta version dolphin-master-4.0-8010. PD: se mantiene este error hasta la compilacion dolphin-master-4.0-8054. Solo informaba, saludos English (Google traslator) (si no se entiende bien, alguna persona podría traducirla por favor, muchas gracias) Hello, since this compilation detects an error in Donkey Kong Country Returns, Donkey Kong character disappears and all the time is displayed, deactivate "Copying EFB scale" run smoothly again, but with lower quality textures donkey kong, compilation dolphin-master-4.0-8008 works well with this version compared dolphin-master-4.0-8010. PD: This error is held until compilation dolphin-master-4.0-8054. Only reported, Greetings |
|
Just to confirm, I also see the same issue as wtonberrios on Linux. Fedora 22 |
As long as an efb copy overlaps a normal texture, copy the overlapping part from the efb copy into the normal texture. Before the pr, this was restricted to efb copies that are completely within the normal texture. This is supposed to fix the invisible character in Donkey Kong Returns, which was caused by dolphin-emu#3165, because it tries to load smaller textures than the created efb copies.
As long as an efb copy overlaps a normal texture, copy the overlapping part from the efb copy into the normal texture. Before the pr, this was restricted to efb copies that are completely within the normal texture. This is supposed to fix the invisible character in Donkey Kong Returns, which was caused by dolphin-emu#3165, because it tries to load smaller textures than the created efb copies.
As long as an efb copy overlaps a normal texture, copy the overlapping part from the efb copy into the normal texture. Before the pr, this was restricted to efb copies that are completely within the normal texture. This is supposed to fix the invisible character in Donkey Kong Returns, which was caused by dolphin-emu#3165, because it tries to load smaller textures than the created efb copies.
As long as an efb copy overlaps a normal texture, copy the overlapping part from the efb copy into the normal texture. Before the pr, this was restricted to efb copies that are completely within the normal texture. This is supposed to fix the invisible character in Donkey Kong Returns, which was caused by dolphin-emu#3165, because it tries to load smaller textures than the created efb copies.
As long as an efb copy overlaps a normal texture, copy the overlapping part from the efb copy into the normal texture. Before the pr, this was restricted to efb copies that are completely within the normal texture. This is supposed to fix the invisible character in Donkey Kong Returns, which was caused by dolphin-emu#3165, because it tries to load smaller textures than the created efb copies.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
This pr fixes another regression that happened after pr dolphin-emu#3165 was merged. The shadows in mario baseball should now work again.
And also keep those efb copies, so they can be used by a future Load() or by partial texture updates.
This fixes some issues in: Sonic Riders: Zero Gravity, Mario Kart Wii and Sonic the Fighters (inside Sonic Gems Collection).