TextureCache: Fix crash for invalid textures. #3268
Conversation
degasus
force-pushed
the
texturecrash
branch
2 times, most recently
from
179ddcf
to
ee2223c
Compare
|
Please update the description to make it more clear the crash only happens when recording fifo logs. Otherwise, LGTM. |
|
Fixes our longstanding medabots infinity crash. |
|
Does it only crash when recording fifologs? Perhaps we should be adding more error checking to FIfoRecorder. |
|
No, it crashes in game normally in D3D and OpenGL (but not SW renderer.) The original fix that @degasus posted only fixed the video-backend part, not the fifoplayer part, which is why he had to add a second fix to the fifoplayer. |
|
OK, I misread that. LGTM then. |
TextureCache: Fix crash for invalid textures.
|
Oh, no, this fixes both, the videocommon part and the fiforecorder, as are broken in the same way here. But my bigger issue with this crash is that it does not happen on videosw. Sounds like the game configures an invalid texture, but don't sample from it. I'm going to verify it if @JMC47 provides me a fifolog. |
No description provided.