DolphinWX: Don't translate OSD messages #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| wxString msg(wxString::Format(_("Wiimote %i %s"), wm_idx + 1, | ||
| connect ? _("Connected") : _("Disconnected"))); | ||
| Core::DisplayMessage(WxStrToStr(msg), 3000); | ||
| const char* message = connect ? "Wiimote %i connected" : "Wiimote %i disconnected"; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JosJuice
force-pushed
the
wiimote-message
branch
from
a931407
to
532dbc3
Compare
JosJuice
changed the title
JosJuice
force-pushed
the
wiimote-message
branch
2 times, most recently
from
3db6142
to
963264a
Compare
|
I would prefer if instead they could be translated, but since this already doesn't work... LGTM. |
OSD messages other than these one and a half aren't translated, and OSD only supports ASCII. (Also, that "Wiimote %i %s" uses %s like it does is bad for translation, but that's easy to fix.)
JosJuice
force-pushed
the
wiimote-message
branch
from
963264a
to
ccc4e6d
Compare
|
Any specific reason for the holdup on this PR? |
|
As far as I know, it's just that nobody has wanted to merge it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSD messages other than these one and a half aren't translated, and OSD only supports ASCII. (Also, that "Wiimote %i %s" uses %s like it does is bad for translation, but that's easy to fix.)