DolphinWX: Fix label change for the play/pause button #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowsFriend
force-pushed
the
pausebutton_fix
branch
from
1f87b78
to
95847dc
Compare
This fixes changing the play/pause button's label depending on the emulation state. Before, wxToolBarToolBase's SetLabel() function was used. This function, however, is not implemented in wxGTK which leads to the label not changing on linux when the button is clicked. Although the preferred method (according to the wxWidgets documentation) to change the properties of a tool is to use the toolbar's setters, there is no such setter for the label. Therefore, this implements a workaround where the button is deleted and readded afterwards with the updated properties. Thanks to linkmauve for noticing this!
ShadowsFriend
force-pushed
the
pausebutton_fix
branch
from
95847dc
to
33487ab
Compare
|
@dolphin-emu-bot rebuild |
|
I'm not on a Linux machine to test this and won't be until probably Friday, but the code LGTM. |
degasus
added a commit
that referenced
this pull request
Dec 15, 2015
DolphinWX: Fix label change for the play/pause button
EmptyChaos
added a commit
to EmptyChaos/dolphin
that referenced
this pull request
Mar 14, 2016
EmptyChaos
added a commit
to EmptyChaos/dolphin
that referenced
this pull request
Mar 14, 2016
Followed from PR dolphin-emu#3333.
EmptyChaos
added a commit
to EmptyChaos/dolphin
that referenced
this pull request
Mar 14, 2016
Followed from PR dolphin-emu#3333.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes changing the play/pause button's label depending on the
emulation state. Before, wxToolBarToolBase's SetLabel() function was
used. This function, however, is not implemented in wxGTK which leads to
the label not changing on linux when the button is clicked. Although the preferred
method (according to the wxWidgets documentation) to change the properties
of a tool is to use the toolbar's setters, there is no such setter for
the label. Therefore, this implements a workaround where the
button is deleted and readded afterwards with the updated properties.
Thanks to linkmauve for noticing this!