DolphinWX: Fix items vanishing from toolbar #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 33487ab introduced a regression where items would vanish from the toolbar. This adds a call to Realize() after the reinsertions of the play/pause button as required per documentation. Thanks to Simonwayneee for noticing this!
|
Tested & works. LGTM. |
degasus
added a commit
that referenced
this pull request
Dec 16, 2015
DolphinWX: Fix items vanishing from toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 33487ab introduced a regression
where items would vanish from the toolbar, that means that after a while -- probably after clicking the play/pause button a few times -- only Open, Refresh and Browse remain in the toolbar with the rest of it being empty. I assume the missing call to Realize(), which is required as per the wxWidgets documentation, after the reinsertions of the play/pause button is the culprit. Unfortunately, I cannot reproduce the issue as it seems to not show on every OS and I can only test on Linux. It would be great if someone with access to Windows and/or Mac OS X could test whether this really fixes the issue.
Edit: https://bugs.dolphin-emu.org/issues/9161 describes the issue including a video and steps to reproduce.