Replace some unnamed tick constants with GetTicksPerSecond() #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This changes the behavior on the Wii a bit, but I doubt it matters. |
JosJuice
force-pushed
the
seconds-not-ticks
branch
from
bd92c71
to
996e6c0
Compare
|
Reviewed 4 of 4 files at r1. Comments from the review on Reviewable.io |
|
Reviewed 4 of 4 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
JosJuice
force-pushed
the
seconds-not-ticks
branch
from
996e6c0
to
3cb67d4
Compare
JosJuice
force-pushed
the
seconds-not-ticks
branch
from
3cb67d4
to
4e4ecf0
Compare
These operations should always take the same amount of time, not the same amount of ticks. The number of ticks per second is different for GameCube and Wii.
JosJuice
force-pushed
the
seconds-not-ticks
branch
from
4e4ecf0
to
b8e04c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operations should always take the same amount of time, not the same amount of ticks. The number of ticks per second is different for GameCube and Wii.