Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: asterisks go against the type name #3544

Merged
merged 4 commits into from
Jan 21, 2016

Conversation

mathieui
Copy link
Member

not the variable name

Review on Reviewable

@delroth
Copy link
Member

delroth commented Jan 21, 2016

Please be more consistent in applying this so we can avoid followup commits. I've seen some missing and I've only looked at the few lines surrounding each of your changes.


Reviewed 22 of 22 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.


Source/Core/Common/Arm64Emitter.h, line 101 [r1] (raw file):
What about these ones?


Source/Core/Common/StringUtil.cpp, line 191 [r1] (raw file):
What about these?


Source/Core/Common/SymbolDB.h, line 98 [r1] (raw file):
What about these?


Source/Core/Common/x64Analyzer.cpp, line 7 [r1] (raw file):
You're missing one of two.


Source/Core/Common/x64Analyzer.h, line 44 [r1] (raw file):
Missing one of two.


Comments from the review on Reviewable.io

@mathieui
Copy link
Member Author

It should be a bit more complete now, I’m doing ampersands in the next commit

@delroth
Copy link
Member

delroth commented Jan 21, 2016

Reviewed 19 of 33 files at r2, 17 of 17 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


Source/Core/Common/Arm64Emitter.h, line 736 [r3] (raw file):
This still has a space.


Source/Core/Common/Hash.cpp, line 235 [r3] (raw file):
Extra space within the cast.


Source/Core/Common/ucrtFreadWorkaround.cpp, line 38 [r3] (raw file):
Extra space in the cast here too.


Comments from the review on Reviewable.io

@delroth
Copy link
Member

delroth commented Jan 21, 2016

LGTM


Reviewed 5 of 6 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

delroth added a commit that referenced this pull request Jan 21, 2016
Common: asterisks go against the type name
@delroth delroth merged commit 338714a into dolphin-emu:master Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants