Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some OpenGL 4.5 functions until AMD fixes their trash driver. #3640

Merged

Conversation

Sonicadvance1
Copy link
Contributor

Review on Reviewable

@delroth
Copy link
Member

delroth commented Feb 16, 2016

I don't really like this (I think we should fallback to 4.4, not 2.0), but let's fix the breakage for now.

delroth added a commit that referenced this pull request Feb 16, 2016
…rash

Disable some OpenGL 4.5 functions until AMD fixes their trash driver.
@delroth delroth merged commit d4b67be into dolphin-emu:master Feb 16, 2016
@Nucleoprotein
Copy link

I don't think they (AMD) care, because of today's Vulkan 1.0 "premiere". Vulkan was designed from their Mantle API so I think they will be fully going into it.
Drivers are available for AMD (Windows only - http://support.amd.com/en-us/kb-articles/Pages/radeon-vulkan-beta.aspx ) and Nvidia (Windows / Linux - https://developer.nvidia.com/vulkan-driver ), Intel driver will be soon available.
Maybe time to start writing Vulkan renderer as it will be supported on mobile devices too in future.

@MayImilae
Copy link
Contributor

Note that this error that this fixed also occurred on working GPUs with older drivers that didn't support OpenGL 4.5 yet. It happened to me!

@delroth
Copy link
Member

delroth commented Feb 16, 2016

@Tapcio please keep the off-topic wishful thinking for our forums please.

@Sonicadvance1 Sonicadvance1 deleted the glextensions_workaround_trash branch February 21, 2016 03:23
@Nucleoprotein
Copy link

I checked AMD OpenGL driver (64bit one, atio6axx.dll) for those strings, and there are in the driver binary but with ARB extension (even in old 15.7.1). I think AMD implement those function only with GL_ARB_robustness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants