Updated D3D12 to build on the newer windows 10 sdk.

[phire]

This won't build on the buildbots until they are updated to the new sdk.

[valkyrieBae]

Well that explains why I was struggling with it x_x

On Thu, Feb 18, 2016, 10:23 PM Scott Mansell notifications@github.com
wrote:

This won't build on the buildbots until they are updated to the new sdk.

You can view, comment on, or merge this pull request online at:

#3656
Commit Summary

• Updated D3D12 to build on the newer windows 10 sdk.

File Changes

• M Source/Core/VideoBackends/D3D12/D3D12.vcxproj
  https://github.com/dolphin-emu/dolphin/pull/3656/files#diff-0 (2)
• M Source/Core/VideoBackends/D3D12/D3DQueuedCommandList.cpp
  https://github.com/dolphin-emu/dolphin/pull/3656/files#diff-1 (2)
• M Source/Core/VideoBackends/D3D12/D3DQueuedCommandList.h
  https://github.com/dolphin-emu/dolphin/pull/3656/files#diff-2 (4)

Patch Links:

• https://github.com/dolphin-emu/dolphin/pull/3656.patch
• https://github.com/dolphin-emu/dolphin/pull/3656.diff

—
Reply to this email directly or view it on GitHub
#3656.

[Helios747]

Is there any way we can distribute the headers with the source? Or does Microsoft's license explicitly make this not compatible with our GPL license?

[phire]

They are copyright Microsoft, no license specified.

[JosJuice]

Should we try to get this into 5.0? It would be annoying to have to use an old SDK version to build it.

[sepalani]

I don't know, it's an annoyance for developers with the latest SDKs but it doesn't bother users since they don't compile Dolphin.

Alternatively, we can fix this by implementing both functions and call the const one in the non-const one. It won't break anything (I hope) and both SDKs would be supported even though there will be a function just for the sake of code legacy...

[delroth]

@Parlane can you take care of that with phire?

[Parlane]

Yep in 3 hours I should be at a PC
On 26/03/2016 1:43 pm, "Pierre Bourdon" notifications@github.com wrote:

@Parlane https://github.com/Parlane can you take care of that with
phire?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3656 (comment)

[Parlane]

@dolphin-emu-bot rebuild

[degasus]

works fine here.