[DVD] Ignore buffer when seeking backwards #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
Based on us talking in IRC, it seems like the code before PR #3632 was actually working correctly, but it was non-obvious that it was working correctly because it relied on underflow. PR #3632 made the behavior wrong. This PR brings back the correct behavior, written in a way that's easier to understand. |
|
Do not merge yet -- I'm going to try and reason through this. |
mmastrac
force-pushed
the
dvd_nobackwardsbuffer
branch
from
abb5c4e
to
f1a5d6c
Compare
Unfortunately this fix re-breaks Arc Rise Fantasia, so we must restore its INI as well.
|
Reviewed 1 of 1 files at r2. Comments from the review on Reviewable.io |
delroth
added a commit
that referenced
this pull request
Feb 26, 2016
[DVD] Ignore buffer when seeking backwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Shrek 2, but needs some testing on other titles that might have broken with the previous signedness fix.
The buffer definitely shouldn't be used for large backwards seeks, but with this patch we're also ignoring it for small backwards seeks. This may be a reasonable assumption.