-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround OS X video driver bug #24983074 #3719
Workaround OS X video driver bug #24983074 #3719
Conversation
Haven't tested this on an actual Apple product because I don't own one. |
Just out of curiosity, which GPUs have been tested to fail? The compiler varies depending on the vendor architecture. |
Any GPU supporting geometry shaders |
Tested and no longer receiving errors with 8x SSAA enabled. |
Just tested on a Mac with Intel Iris Graphics. SSAA now runs fine, but it breaks MSAA.
|
OS X's shader compiler has a bug with interface blocks where interface block members don't properly inherit the layout qualifier from the interface block. Work around this limitation by explicitly stating the layout qualifier on both the interface block and every single member inside of that block.
84344cd
to
3ab7806
Compare
Fixed the issue with MSAA in the latest push. |
Tested again on a Mac with Intel Iris Graphics : both MSAA and SSAA works 👍 |
@dolphin-emu-bot rebuild |
OS X's shader compiler has a bug with interface blocks where interface block members don't properly inherit the layout qualifier from the interface
block.
Work around this limitation by explicitly stating the layout qualifier on both the interface block and every single member inside of that block.
This should fix issue #9361