Always clear memory when booting #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading uninitalized memory is non-deterministic. We used to only clear the memory when using EmulatedBS2_GC or FifoPlayer, but we now do it during Memory::Init instead so it always gets done.
|
Looks good(ish) to me, but I haven't checked all calling sites for |
|
@delroth Is this okay to include in 5.0? |
|
I'm happy that you moved this out of the BS2 nonsense and in the actual memory subsystem. Thought it was dumb missing on the Wii side of things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading uninitalized memory is non-deterministic. We used to only clear the memory when using EmulatedBS2_GC or FifoPlayer, but we now do it during Memory::Init instead so it always gets done.
I'm not especially familiar with this part of the code, so I'm not sure if the change is correct.
This change is