VideoCommon: Workaround Intel OS X bug again

[endrift]

This time without the behavior change of the last patch. Reverts the last patch. Thanks, Apple. Thapple.

---

This change is

[degasus]

Restores the old behavior + simplifys the code.

LGTM

[mimimi085181]

So this would reintroduce the bugs that pr #3570 fixed? I take it, you tried to find a solution that works for all drivers? What about combing this revert with: pr #3784 ? (just a random guess)

If this reintroduces bugs that were fixed, would it be justified to add specific driver workarounds for 5.0?

[RisingFog]

@mimimi085181 it fixes the bug in a different way if I read it correctly

[endrift]

@mimimi085181 This does not reintroduce the old bug. It looks like the original bug had something to do with sequence points or order of operations in the code getting done wrong (?????), which would imply 100% that it's a driver bug in Intel. Regardless, this reverts a behavior change that wasn't shown to be 100% necessary while fixing the bug, so it's much nicer in that regard, and may fix the AMD bug as well (yet to be shown).

[RisingFog]

@dolphin-emu-bot rebuild

[endrift]

I've just confirmed that this fixes the dff in https://bugs.dolphin-emu.org/issues/9468

[mimimi085181]

Nice, now maybe some other systems should be tested as well. Like the ones that were broken before the orignal pr.

[endrift]

It doesn't affect the ea-vp6.dff on any platform I tested it on, I don't think.

[endrift]

Anything holding this up now?

[degasus]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[degasus]

Nope. @delroth ready to merge.

[phire]

We still need to do hardware tests in the future, but LGTM

[RisingFog]

@dolphin-emu-bot rebuild

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• rs3-bumpmapping on ogl-lin-intel: diff
• sadx-ui on ogl-lin-intel: diff
• smg2-fog on ogl-lin-intel: diff
• sms-bubbles on ogl-lin-intel: diff
• sonic-riders-blur on ogl-lin-intel: diff
• rs3-bumpmapping on ogl-lin-mesa: diff
• sadx-ui on ogl-lin-mesa: diff
• smg2-fog on ogl-lin-mesa: diff
• sms-bubbles on ogl-lin-mesa: diff
• sonic-riders-blur on ogl-lin-mesa: diff

_{^{automated-fifoci-reporter}}