Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game INI updates #3852

Merged
merged 1 commit into from
May 24, 2016
Merged

Game INI updates #3852

merged 1 commit into from
May 24, 2016

Conversation

@RisingFog
Copy link
Member

Reviewed 2 of 5 files at r1.
Review status: 2 of 5 files reviewed at latest revision, 3 unresolved discussions.


Data/Sys/GameSettings/RIZ.ini, line 8 [r1] (raw file):

[EmuState]
# The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 

Missing emulation state value. Should also mention needing Real XFB in Emulation issues below.


Data/Sys/GameSettings/RWO.ini, line 9 [r1] (raw file):

# The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 4
EmulationIssues =

Maybe have something here for emulation issues?


Data/Sys/GameSettings/SPR.ini, line 8 [r1] (raw file):

[EmuState]
# The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 

Here as well.


Comments from Reviewable

@JosJuice
Copy link
Member Author

Review status: 2 of 5 files reviewed at latest revision, 3 unresolved discussions.


Data/Sys/GameSettings/RIZ.ini, line 8 [r1] (raw file):

Previously, RisingFog (Chris Burgener) wrote…

Missing emulation state value. Should also mention needing Real XFB in Emulation issues below.

Emulation ratings aren't mandatory. I suppose I simply can copy it from the wiki, though.

This game does not need real XFB. If you want the INI to have a note saying why virtual XFB is required, you'll need to ask JMC, because he hasn't why yet as far as I know.


Data/Sys/GameSettings/RWO.ini, line 9 [r1] (raw file):

Previously, RisingFog (Chris Burgener) wrote…

Maybe have something here for emulation issues?

Is this needed? ping @JMC47

Comments from Reviewable

@RisingFog
Copy link
Member

Reviewed 1 of 5 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Data/Sys/GameSettings/RWO.ini, line 9 [r1] (raw file):

Previously, JosJuice wrote…

Is this needed? ping @JMC47

I guess not

Comments from Reviewable

@RisingFog
Copy link
Member

You'll need to add FastDiscSpeed = True to GC3.ini to resolve 9561: https://bugs.dolphin-emu.org/issues/9561

@JosJuice
Copy link
Member Author

Done.

@JMC47
Copy link
Contributor

JMC47 commented May 21, 2016

Did you actually test Kirby Air Ride + Ignore Format Changes? If not, I can do so for you.

@JMC47
Copy link
Contributor

JMC47 commented May 21, 2016

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, 2 of 3 files at r3, 1 of 1 files at r4.
Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion.


Data/Sys/GameSettings/GC3.ini, line 5 [r4] (raw file):

[Core]
# Values set here will override the main Dolphin settings.
FastDiscSpeed = True

Please add a comment stating why fast-disc speed was enabled. It crashes after the first level.


Comments from Reviewable

@JMC47
Copy link
Contributor

JMC47 commented May 21, 2016

Reviewed 1 of 3 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@JosJuice
Copy link
Member Author

JosJuice commented May 21, 2016

I haven't tested Kirby's Air Ride. I would appreciate if you could do it.

@JMC47
Copy link
Contributor

JMC47 commented May 21, 2016

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@JMC47
Copy link
Contributor

JMC47 commented May 21, 2016

:lgtm:

Previously, JosJuice wrote…

I haven't tested Kirby's Air Ride. I would appreciate if you could do it.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@JMC47
Copy link
Contributor

JMC47 commented May 21, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion.


Data/Sys/GameSettings/GC3.ini, line 5 [r4] (raw file):

Previously, JMC47 wrote…

Please add a comment stating why fast-disc speed was enabled. It crashes after the first level.

OK

Comments from Reviewable

@JMC47
Copy link
Contributor

JMC47 commented May 23, 2016

Reviewed 4 of 4 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@degasus degasus added this to the Dolphin Release 5.0 milestone May 24, 2016
@degasus degasus merged commit 34e315b into dolphin-emu:master May 24, 2016
@JosJuice JosJuice deleted the game-inis-2016-05-19 branch May 24, 2016 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants