Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Menu Capitalization #3936

Merged
merged 3 commits into from Jul 14, 2016
Merged

Fix Menu Capitalization #3936

merged 3 commits into from Jul 14, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 25, 2016

The capitalization of the debug menu is inconsistent in many places. This should bring it in line with how the the rest of the menu is capitalized.


This change is Reviewable

pCoreMenu->Append(IDM_LOG_INSTRUCTIONS, _("&Log JIT instruction coverage"));
pCoreMenu->Append(IDM_SEARCH_INSTRUCTION, _("&Search for an op"));
pCoreMenu->Append(IDM_LOG_INSTRUCTIONS, _("&Log JIT Instruction Coverage"));
pCoreMenu->Append(IDM_SEARCH_INSTRUCTION, _("&Search for an Op"));

This comment was marked as off-topic.

pCoreMenu->Append(IDM_JIT_LSF_OFF, _("&JIT LoadStore Floating Off"), wxEmptyString, wxITEM_CHECK);
pCoreMenu->Append(IDM_JIT_LSP_OFF, _("&JIT LoadStore Paired Off"), wxEmptyString, wxITEM_CHECK);
pCoreMenu->Append(IDM_JIT_FP_OFF, _("&JIT FloatingPoint Off"), wxEmptyString, wxITEM_CHECK);
pCoreMenu->Append(IDM_JIT_I_OFF, _("&JIT Integer Off"), wxEmptyString, wxITEM_CHECK);
pCoreMenu->Append(IDM_JIT_P_OFF, _("&JIT Paired off"), wxEmptyString, wxITEM_CHECK);

This comment was marked as off-topic.

@JosJuice
Copy link
Member

JosJuice commented Jul 6, 2016

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@phire
Copy link
Member

phire commented Jul 6, 2016

:lgtm:


Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@Parlane
Copy link
Member

Parlane commented Jul 14, 2016

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Source/Core/DolphinWX/Debugger/CodeWindow.cpp, line 466 [r1] (raw file):

Previously, BhaaLseN (BhaaL) wrote…

Maybe we can rename this "op" to "instruction" while we're at it? Otherwise just upper-casing it looks a little strange to me.

I'm ok with this being Instruction tbh.

Comments from Reviewable

@Parlane Parlane merged commit ca8484c into dolphin-emu:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants