Add MOV optimizations and MOV_sum #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| MOV(bits, R(dest), a1); | ||
| return; | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM otherwise. |
mmastrac
force-pushed
the
mov_sum
branch
2 times, most recently
from
7352ce4
to
e41c400
Compare
|
Reviewed 2 of 22 files at r1, 3 of 9 files at r2. Comments from Reviewable |
Replaces incarnations of the A=B+C pattern throughout the code so we can apply optimizations consistently.
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
CarlKenner
pushed a commit
to CarlKenner/dolphin
that referenced
this pull request
Jun 28, 2016
Add MOV optimizations and MOV_sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring that replaces the A=B+C pattern throughout the code with a
MOV_summeta-instruction so we can apply optimizations consistently.This shouldn't have any performance implications one way or another, but it paves the way for the code refactoring in #3565
Split into a separate PR per discussion w / @magumagu
This change is