DVDInterface: Simplify calling ChangeDisc from CPU thread #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Movie was calling ChangeDisc, it was moving execution to the host thread just to then make the host thread the CPU thread. We can simply run the code directly on the CPU thread instead.
JosJuice
changed the title
|
This looks right in terms of synchronization. (It isn't really right in the sense that the disc change doesn't happen at the right time if you record a movie without using frame advance, but that's an existing issue.) |
|
Yeah, this looks right |
|
@JosJuice I believe this should be correct. |
|
Reviewed 6 of 6 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Movie was calling ChangeDisc, it was moving execution to the host thread just to then make the host thread the CPU thread. We can simply run the code directly on the CPU thread instead.
This works as far as I could see during my testing, but I'm not completely sure about the correctness. Since PR #3794 was the last major edit to this, @EmptyChaos, do you want to comment?
This change is