Remove VI count limit on Movie playback #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,7 +312,9 @@ void Renderer::DrawDebugText() | |||
| { | |||
| final_cyan += StringFromFormat("Frame: %llu", (unsigned long long)Movie::g_currentFrame); | |||
| if (Movie::IsPlayingInput()) | |||
| final_cyan += StringFromFormat(" / %llu", (unsigned long long)Movie::g_totalFrames); | |||
| final_cyan += | |||
| StringFromFormat("/nInput: %llu / %llu", (unsigned long long)Movie::g_currentInputCount, | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
RisingFog
force-pushed
the
remove_vi_movie_playback
branch
from
500ab21
to
d00c013
Compare
|
The code Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the check of VI count when playing back the movie. VI counts can differ between NoXFB, VirtualXFB, and RealXFB, but the inputs will work across all three without any issues.
Because we're no longer checking for VI count when playing back the movie, I've also de-prioritized the VI count when either recording or playing back a movie, with Input Count taking priority.
This change is