ControllerEmu: Split the Setting class #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this keep compatibility with old settings files? |
|
Hmm, I hadn't thought about that. Most settings should work just fine, but I'll check for the 1.0 => True change. |
The Setting class was used for both numeric values and booleans, and other parts of the code had hacks to make it work with booleans. By splitting Setting into NumericSetting and BooleanSetting, it is clear which settings are numeric, and which are boolean, so there is no need to guess by checking the default values or anything like that. Also, booleans are stored as booleans in config files, instead of 1.0.
leoetlino
force-pushed
the
split-controller-setting
branch
from
58ad9ca
to
5e99021
Compare
This is needed to keep compatibility with old configuration files which didn't store booleans as booleans, but as floats/doubles.
leoetlino
force-pushed
the
split-controller-setting
branch
from
5e99021
to
213373f
Compare
|
This should now be able to parse 1.0000000000000000 (which is how True was stored previously) as true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Setting class was used for both numeric values and booleans, and
other parts of the code had "hacks" to make it work with booleans.
By splitting Setting into NumericSetting and BooleanSetting, it is
clearer which settings are numeric, and which are boolean, so there is
no need to guess by checking the default values or anything like that.
Also, booleans are stored as booleans in config files, instead of 1.0.
This change is