POSIX includes portability #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please replace the commit with one that uses the include order that clang-format enforces: https://buildbot.dolphin-emu.org/builders/lint/builds/2002/steps/shell/logs/stdio |
| @@ -6,6 +6,7 @@ | |||
| #ifndef _WIN32 | |||
| #include <unistd.h> | |||
| #endif | |||
| #include <arpa/inet.h> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
POSIX specifies that inet_ntoa() is declared in arpa/inet.h, and that POLLRDNORM, etc. are defined in poll.h. gethostbyname() is not specified by POSIX, but the manpages in OpenBSD, FreeBSD, OS X, and glibc all state that it is declared in netdb.h. Without these headers, the build fails on OpenBSD and possibly other systems.
|
Updated to wrap these headers in |
Closed
|
Reviewed 2 of 2 files at r3. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX specifies that inet_ntoa() is declared in arpa/inet.h, and that
POLLRDNORM, etc. are defined in poll.h.
gethostbyname() is not specified by POSIX, but the manpages in OpenBSD,
FreeBSD, OS X, and glibc all state that it is declared in netdb.h.
Without these headers, the build fails on OpenBSD and possibly other
POSIX-conforming systems.
This change is