Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Menu Ellipses Usage #4056

Merged
merged 1 commit into from Sep 16, 2016
Merged

Update Menu Ellipses Usage #4056

merged 1 commit into from Sep 16, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 23, 2016

Ellipses should be used in menu options when an operation requires further user input before being carried out (see: http://stackoverflow.com/questions/637683/when-to-use-ellipsis-after-menu-items/637708#637708). Dolphin isn't completely consistent with that so I edited a few options to be more aligned with that approach. That being said many programs don't seem to follow this convention 100% and I would be open to changing some of these if others disagree with my selections.


This change is Reviewable

@RisingFog
Copy link
Member

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@JosJuice JosJuice merged commit 22b5d89 into dolphin-emu:master Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants