Don't use the fast path when there are watchpoints enabled, for writes too #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s too. Also fold the check in both functionss into 'slowmem' rather than having a separate test. (jo.alwaysUseMemFuncs implies jo.memcheck anyway, as makes sense.)
comex
force-pushed
the
alwaysUseMemFuncs-for-write
branch
from
32c3a9a
to
c51faa4
Compare
|
After the edit you made, the write memory checks now work on my end! thank you :D EDIT: however, I just noticed it now slows down by half compared to using a memory check without this commit applied... |
Makes sense, since a whole lot of memory accesses are no longer using the fast path... Still, this change is correct, and optimization (which is very possible) should come separately. |
comex
changed the title
|
Apart from that, LGTM Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. Source/Core/Core/PowerPC/JitCommon/Jit_Util.cpp, line 353 [r1] (raw file):
This if condition can be simplified too. Comments from Reviewable |
aldelaro5
pushed a commit
to aldelaro5/dolphin
that referenced
this pull request
Sep 5, 2016
phire
added a commit
that referenced
this pull request
Sep 6, 2016
Simplify an if condition after PR #4078
OrN
pushed a commit
to OrN/dolphin
that referenced
this pull request
Sep 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is