TASInputDlg: Fix inputs "sticking" after closing (Issue 9748) #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good, but I wasn't able to re-produce the bug in the issue report. Was there a specific method of re-producing it? |
|
@RisingFog Try opening a menu screen that supports the DPad for navigation (I used Mario Kart Wii with an emulated GCPad), tick "Down" then close the TAS dialog. Move the game's cursor back to the top, open the TAS dialog again. The game should scroll down to the bottom of the menu as though Down is held. |
|
Oh, so it kept the value that was last held down, despite not showing it. |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug I accidentally introduced during PR #3794, the state variables are not being reset by
ResetValues.This change is