VideoBackends: Capture screenshots at the internal resolution. #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates higher resolution screenshots, but forgoes post-processing. The XFB is way too complex to do this though, so we just capture the backbuffer in that case.
Generates higher resolution screenshots, but forgoes post-processing. The XFB is way too complex to do this though, so we just capture the backbuffer in that case.
|
This functionality can be implemented much more cleanly in PR #3880, I will wait until that PR is merged. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates higher resolution screenshots, but forgoes post-processing on OGL. The XFB is way too complex to do this though, so we just capture the backbuffer in that case.
If the user still wants to capture a screenshot with postprocessing, there are plenty of way to capture the render window by using features from the operating system.
This change is