Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Handle forced aspect ratio changes at runtime #4315

Merged
merged 1 commit into from
Oct 8, 2016
Merged

Vulkan: Handle forced aspect ratio changes at runtime #4315

merged 1 commit into from
Oct 8, 2016

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Oct 7, 2016

Fixes issue 9824.

Also removes a potential hazard when changing MSAA modes on the fly.


This change is Reviewable

@degasus
Copy link
Member

degasus commented Oct 8, 2016

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Source/Core/VideoBackends/Vulkan/Renderer.cpp, line 942 at r1 (raw file):

  bool stereo_changed = g_Config.iStereoMode != g_ActiveConfig.iStereoMode;
  bool efb_scale_changed = s_last_efb_scale != g_ActiveConfig.iEFBScale;
  bool aspect_changed = g_Config.iAspectRatio != g_ActiveConfig.iAspectRatio;

oh, using g_Config is a race condition here AFAIK. c_Config is written by the UI thread.


Comments from Reviewable

@degasus degasus merged commit 6e8901d into dolphin-emu:master Oct 8, 2016
@stenzek stenzek deleted the vulkan-aspect branch November 13, 2016 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants