Framedump: General code cleanup. #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionally seems good to me. |
This was needed with fixed framerate dumping. As we now synchronize the frames, the last one will just get padded.
degasus
changed the title
|
Reviewed 8 of 8 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepeatFrameDumpFrame was used to duplicate frames. As we do this internally for AVIDump, too, this is redundant.
This PR also creates a new stup function FinishFrameData, it shall be used to mark the pointer given by DumpFrameData as invalid. Right now, no threading is done, but this will conflict backend and VideoCommon parts. So I'm adding this patch now.
The last two patches adds custom row_strides, so we don't need to convert the D3D textures any more.
This change is