Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxWidgets: Fix build on case-sensitive macOS #4359

Merged
merged 1 commit into from
Oct 21, 2016

Conversation

VinDuv
Copy link
Contributor

@VinDuv VinDuv commented Oct 16, 2016

On macOS, wxWidget’s tooltip.mm tries to include a system header with an improper capitalization (Appkit instead of AppKit), which causes the build to fail if the system headers are located on a case-sensitive filesystem.

This is already fixed upstream: wxWidgets/wxWidgets#284 (but not in a released version, it seems).


This change is Reviewable

On macOS, wxWidget’s tooltip.mm tries to include a system header with an improper capitalization (Appkit instead of AppKit), which causes the build to fail if the system headers are located on a case-sensitive filesystem.
@JosJuice
Copy link
Member

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Helios747 Helios747 merged commit 500175a into dolphin-emu:master Oct 21, 2016
@VinDuv VinDuv deleted the build-fixes branch October 25, 2016 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants