DiscIO/SConfig: Rename GetUniqueID to GetGameID #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
approved these changes
Oct 29, 2016
| // Use the TitleIDhex for name and/or unique ID if launching from nand folder | ||
| // or if it is not ascii characters (specifically sysmenu could potentially apply to other | ||
| // things) | ||
| // Use the TitleIDhex for name and/or unique ID if launching |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
We call this "game ID" everywhere else, and it's not actually completely unique.
JosJuice
force-pushed
the
rename-getuniqueid
branch
from
ff1f840
to
1081497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call this "game ID" everywhere else, and it's not actually completely unique.
This change is