Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Support dumping frames to images #4455

Merged
merged 1 commit into from Nov 28, 2016
Merged

VideoCommon: Support dumping frames to images #4455

merged 1 commit into from Nov 28, 2016

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Nov 18, 2016

This enables support for dumping frames to a series of png files instead of an avi file.
Therefore, we can support frame dumping on Android, or other platforms where libav is not available.

I haven't tested this at all on Android, but I don't see why it shouldn't work.

Note: I haven't made any changes to the Android UI, if we were to add an option for it, it'd probably be best placed in menu that is accessible at runtime, rather than the main settings menu as you wouldn't want to leave it enabled for long, due to how many files would be created.


This change is Reviewable

This is mainly for potential Android fifoci usage, and thus is not
exposed anywhere in the UI. To enable, set DumpFramesAsImages under
Settings in GFX.ini.
@degasus
Copy link
Member

degasus commented Nov 28, 2016

:lgtm: Do you want to update fifoci to use this new feature? I doubt there is a need to export everything at 60 fps in fifoci as AVIDump does. https://github.com/dolphin-emu/fifoci/blob/master/runner/linux/run_fifo_test.sh#L110


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@stenzek stenzek merged commit 6812945 into dolphin-emu:master Nov 28, 2016
@stenzek stenzek deleted the png-frame-dumping branch June 13, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants