D3D/Vulkan: Handle strided XFB copies #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where src_rect.width * 2 != dst_stride.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two backends assumed that the stride would always be equal to the width of the copy region * 2. It's possible to specify a larger stride, in which case the region outside the copy region should be untouched. GL was already behaving correctly in this regard.
Vulkan was also using a point sampler instead of a linear sampler, which would result in a lack of filtering if y-scaling was enabled for the copy.
Should hopefully fix VC Earthworm Jim, possibly others that rely on this behavior.
This change is