Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinNoGUI: Receive resize events and notify backend when this occurs #4459

Merged
merged 1 commit into from Nov 28, 2016
Merged

DolphinNoGUI: Receive resize events and notify backend when this occurs #4459

merged 1 commit into from Nov 28, 2016

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Nov 19, 2016

Solves the viewport sizing issue for backends that cannot tell when the window is resized (Vulkan on NV at least).

Should fix this issue: https://bugs.dolphin-emu.org/issues/9894

There's some duplication in the event handler here, we could probably XGetGeometry call by using the event instead, might do this if it fixes the issue linked.


This change is Reviewable

Solves the viewport sizing issue for backends that cannot tell when the
window is resized (Vulkan on NV at least).
@degasus
Copy link
Member

degasus commented Nov 28, 2016

LGTM

Do you think it's worth to implement this kind of logic also with WX?
https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/VideoBackends/OGL/Render.cpp#L1777


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@stenzek
Copy link
Contributor Author

stenzek commented Nov 28, 2016

I think it'd be a good idea, and it's something I've been wanting to do for a while now (at least getting rid of the polling each frame).


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@stenzek stenzek merged commit 49e807b into dolphin-emu:master Nov 28, 2016
@stenzek stenzek deleted the nogui-resize-notify branch June 13, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants