Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit64: Minor Typo Fix #4466

Merged
merged 1 commit into from Nov 22, 2016
Merged

Jit64: Minor Typo Fix #4466

merged 1 commit into from Nov 22, 2016

Conversation

Ebola16
Copy link
Member

@Ebola16 Ebola16 commented Nov 22, 2016

The real purpose of this is to understand if I'm properly making a PR. I made my commit on a branch from the clone of my fork in Visual Studio 2015. I then pushed the clone's commit to my fork. I had to open GitHub in my browser to make this pull request from my fork though. Is there a way I can create a pull request only through Visual Studio?

Please let me know if this is the most efficient method. Thanks!


This change is Reviewable

@aldelaro5
Copy link
Member

@Ebola16 There is an extension to visual studio to have github integration and from the little I used it, I think it did allow to make PR from it.

But personally, I prefer using the browser so I can ensure the diff is what I want. Both method works here.

As for the general idea, yeah this is how you would do a pr. You don't have to use the git client in visual studio, any clients would do even the terminal one. Just use the one you prefer.

So you're doing it right here.

@Helios747
Copy link
Contributor

@dolphin-emu-bot rebuild

There is no way to create a PR from visual studio. Your process is fine if it works for you. My only suggestion if you wish to get more into development in the future would be to commit your changes to a separate branch within your fork. That way the changes you're working on can be kept separate to what master is currently at, and you can work on multiple changes at once if your ambitions carry you that far.

Anyways, thanks for the typo fix. Just checking to see if linter is happy before I merge this

@Helios747 Helios747 merged commit b6f9bdf into dolphin-emu:master Nov 22, 2016
@Ebola16
Copy link
Member Author

Ebola16 commented Nov 22, 2016

Thanks for the responses aldelaro5 and Helios747. I want to create my pull requests entirely in Visual Studio since it has nice integration with the Visual Studio debugger but it appears that is not possible. I hope Visual Studio will eventually fix that problem with their GitHub extension!

I'll look into browser GitHub more and continue testing my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants