Add cmake options to disable optional dependencies #4487
Conversation
|
Should hires textures ever be disabled? That seems like one of the big selling points of Dolphin. Maybe an option to force building the local copy of SOIL would be better. |
|
I guess most people never once tried this feature, nor know anything about it, or don’t even have a computer powerful enough to use it. But the point of this PR is to make optional dependencies actually optional at build time, so the person building Dolphin doesn’t need to manually remove them from their system in order not to use them. (And my reason for wanting to disable SOIL is to make the nogui frontend build properly even with |
|
Hm, I dislike that the GUI still shows the custom texture option, and we still try to load them but fail. So the usability with disabled SOIL is terrible. But as we should replace SOIL with libpng itself, we hopefully get rid of this at somepoint. so LGTM |
linkmauve
force-pushed
the
optional-dependencies
branch
from
d08e404
to
71654cc
Compare
|
I just dropped the SOIL part from this PR, I will fix that in another PR, this one only does the audio backends, LLVM and Bluetooth now. |
| add_definitions(-DHAVE_ALSA=0) | ||
| message("ALSA NOT found, disabling ALSA sound backend") | ||
| endif(ALSA_FOUND) | ||
| else(ENABLE_ALSA) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
They are already disabled when the libraries can’t be found, this only helps people who want to build without them despite having them installed, for example to provide a package to someone else.
This makes the disassembler only work for x86.
This removes bluetooth support.
linkmauve
force-pushed
the
optional-dependencies
branch
from
71654cc
to
de485f3
Compare
This allows people to build without some of these dependencies even though they are present on the system. This is helpful especially when building a package for other people.