android: Upgrade the Gradle plugin to get the CMake output #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably want to wait for the Gradle plugin 2.3 to be out of beta first. |
|
Yeah, please wait for a stable release. Feel free to also drop the android-cmake-installer reference in https://github.com/dolphin-emu/dolphin/blob/master/AndroidSetup.md |
|
I haven't tried to install CMake with the new plugin, so I'll try it first :) |
|
2.3 is out now. |
degasus
reviewed
Mar 3, 2017
| @@ -3,7 +3,7 @@ apply plugin: 'com.android.application' | |||
| android { | |||
| // Leanback support requires >22 | |||
| compileSdkVersion 24 | |||
| buildToolsVersion '24.0.3' | |||
| buildToolsVersion '25.0.0' | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This was done in #5013 |
|
Yeah, sorry. I was faster :P However, thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.