IOS: Don't expose HLE::Reset() #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an implementation detail that does not have to be exposed. It was used in WII_IPC whenever the IPC gets reset, but that does not make much sense to me: the only time when IOS loses state and the IPC registers are set up again is when it's reloaded. And reloading IOS already calls Reset() indirectly. Also, an IPC reset from the PPC definitely should not close all opened devices! This also gets rid of a special case for clear_devices, which is now completely unneeded.
BhaaLseN
approved these changes
Apr 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation detail that does not have to be exposed.
It was used in WII_IPC whenever the IPC gets reset, but that does not make much sense to me: the only time when IOS loses state and the IPC registers are set up again is when it's reloaded. And reloading IOS already calls Reset() indirectly.
Also, an IPC reset from the PPC definitely should not close all opened devices!
This also gets rid of a special case for clear_devices, which is now completely unneeded.