Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add i18n comments for the acronym IR #5226

Merged
merged 1 commit into from Apr 8, 2017
Merged

Add i18n comments for the acronym IR #5226

merged 1 commit into from Apr 8, 2017

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Apr 8, 2017

No description provided.

@JosJuice
Copy link
Member Author

JosJuice commented Apr 8, 2017

In case you're wondering about the big reformatting in HotkeyManager: It wasn't me, it was clang-format. The only change I made was adding comments.

@leoetlino
Copy link
Member

Can we disable clang-format for that particular table? I don't think it's a good idea to put that many entries on the same line... Imagine having to add/remove/reorder one entry and going through the diff to figure out what changed.

@BhaaLseN
Copy link
Member

BhaaLseN commented Apr 8, 2017

You can, using comments: https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/DSP/DSPTables.cpp#L23
And just noticed this, vertex_rounding_desc uses two spaces after punctation; I think we should at least make this consistent across all the strings?

@JosJuice
Copy link
Member Author

JosJuice commented Apr 8, 2017

@BhaaLseN The spaces are fixed in PR #5227.

@delroth delroth merged commit e7d632d into dolphin-emu:master Apr 8, 2017
@JosJuice JosJuice deleted the ir-18n-comments branch April 8, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@JosJuice @leoetlino @BhaaLseN @delroth