Force SyncGPU on pause

[sepalani]

This PR is an attempt to fix random crashes that happen when the emulator hits a breakpoint (and probably happen when the emulator is paused). It seems that these crashes only happen on dual-core with SyncGPU off, switching to single-core or enabling SyncGPU seems to fix them.

I try to address these by enabling SyncGPU before pausing the emulator. However, even if it works I'm not sure that's the best way to sync the GPU since I mess with the config on the fly. So I'm open to any suggestions.

Regardless, this fix the following issue for me: https://bugs.dolphin-emu.org/issues/10132
And might fix this one as well: https://bugs.dolphin-emu.org/issues/10071

Ready to be reviewed & tested.

[degasus]

AFAIK PauseAndLock should also pause the GPU thread. Is this broken in the latest builds?

[sepalani]

It does happen on latest builds, not sure if it means that's broken, though. Are you sure PauseAndLock can't desync the GPU on dual core? If it can't, then there might something wrong in CPU::EnableStepping or CPU::Break which don't (or can't?) call it, I suppose.

[ghost]

I occasionally experience this issue of crash and freeze using the latest version of dolphin on playstore. Can this PR maybe solve my issue?

[ghost]

How can I test this? there's no apk build 🤔

[gordonfreeman01]

@Gamemulatorer As this PR is quite old, you'd need to resolve the merge conflicts with the latest code version then run your own build to create and APK for testing. You may want to go to the source branch and build the old version but the sheer amount of improvements made since then would render the need for updating the PR a must.

[sepalani]

Closing this since it can be circumvented by using single core and I don't think there is a simple/reasonable way to address the issue.