JitArm64: Drop ps_res instruction. #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The accuracy doesn't match ppc, and worse, it doesn't set the error flags if the input is zero. Lets stop to ship broken instructions, so right now, the interpreter is the closest one.
They are right, our perf query implementation is terrible. But raising a warning makes it just even slower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of ps_res isn't accurate, and it lacks fp exceptions, and it isn't called as often to justify such a speedhack.
Also mute an Nvidia OpenGL warning. We know our code is bad here, no need to waste time on handling this warning.
And give the analytics thread another name, "CPU thread" sounds wrong.