Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt/MappingWindow: Update layout to match WX #5608

Merged
merged 1 commit into from Jun 14, 2017
Merged

Qt/MappingWindow: Update layout to match WX #5608

merged 1 commit into from Jun 14, 2017

Conversation

Starsam80
Copy link
Contributor

Before:
image

After:
image

WX for reference:
image

@MayImilae
Copy link
Contributor

Much better!

I'm curious about something though. Is it possible to expand or contract the window? (In WX it is not) And if so, how does it respond?

@Starsam80
Copy link
Contributor Author

The dialog seems to have a minimum size, but it has no maximum size and appears to just stretch everything horizontally.

Minimum size:
image

As big as I can fit on my screen:
image

The resizing could be improved a lot, but it should be left to another PR as a lot more places in Qt are weird.

MayImilae
MayImilae approved these changes Jun 14, 2017
View reviewed changes
Copy link
Contributor

@MayImilae MayImilae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's still missing indicators (probably best for another PR for that) but this is definitely a step up!

@leoetlino leoetlino merged commit c71cb9a into dolphin-emu:master Jun 14, 2017
@Starsam80 Starsam80 deleted the qt-should-be-like-wx branch June 14, 2017 16:49
@leoetlino leoetlino modified the milestone: Qt Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

@MayImilae MayImilae MayImilae approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Qt
3 participants
@Starsam80 @MayImilae @leoetlino