Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "PreferGLES" option to EGL GLInterface #5826

Conversation

JonnyH
Copy link
Contributor

@JonnyH JonnyH commented Jul 25, 2017

This makes the EGL interface select OpenGL|ES contexts over "desktop"
OpenGL ones, if the "PreferGLES" option is set to True in GFX.ini's [Settings] section.

It's been useful for me for debugging, and others may find it useful too.

Copy link
Member

@linkmauve linkmauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from that one comment, tested and LGTM!

{
// Errored before we found a mode
INFO_LOG(VIDEO, "Error: Failed to detect OpenGL flavour, falling back to OpenGL");
s_opengl_mode = GLInterfaceMode::MODE_OPENGL; // Fall back to OpenGL

This comment was marked as off-topic.

This comment was marked as off-topic.

This makes the EGL interface select OpenGL|ES contexts over "desktop"
OpenGL ones.

Possibly not useful for anyone outside my own debugging, but you never
know
@JonnyH JonnyH force-pushed the WIP/add-option-to-prefer-GLES-when-using-EGL branch from e45ce0e to 0fbd0ca Compare July 27, 2017 02:26
@leoetlino leoetlino merged commit ca49de8 into dolphin-emu:master Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants