GameINI: Replace Wii.Widescreen with AspectRatio #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some users enjoy being wrong and intentionally stretch everything to the width of the screen. This change would prevent them from doing that in Wii games that don't support 16:9. But on the other hand, not having to mess with the SYSCONF is very welcome... Could we add some in-between option that just changes which aspect ratio Dolphin uses when the aspect ratio setting is set to auto, without touching the SYSCONF? |
|
So, an option that would tell Dolphin what aspect ratio is best (for Auto for example), but without forcing the user to use it? |
|
Yes. |
|
I've implemented that idea. |
Wii.Widescreen is a setting that cannot be changed on the fly after emulation has started, so anything booted after the initial title will have an unexpected aspect ratio. We can just set Video_Settings.AspectRatio instead, which *can* be live changed, since it doesn't involve messing with the SYSCONF at any time. This is also much closer to the behaviour of the Wii U, which configures the DMCU to force 4:3 transparently, instead of doing it the intrusive way (touching the SYSCONF).
Instead, add a SuggestedAspectRatio option which tells Dolphin which aspect ratio to use when the aspect ratio option is set to Auto.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wii.Widescreen is a setting that cannot be changed on the fly after emulation has started, so anything booted after the initial title will have an unexpected aspect ratio.
We can just set Video_Settings.AspectRatio instead, which can be live changed, since it doesn't involve messing with the SYSCONF at any time.
This is also much closer to the behaviour of the Wii U, which configures the DMCU to force 4:3 transparently, instead of doing it the intrusive way (touching the SYSCONF). Also more similar to how things would work on a real Wii, where the user would change the TV settings instead of SYSCONF.