DolphinWX: Prevent Dolphin to be shutdown when closing cmd.exe #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this have any other side effect? |
|
Besides preventing the use of stdout/stderr (on Windows) again, I don't think there is any other side effect. Especially, since the only thing writing on stdout/stderr (on Windows) is optparse and that's done during |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That behaviour was introduced while switching to optparse by attaching the console. If FreeConsole isn't called all instances of Dolphin running on that console will get lost. AFAIC, that's not the default behaviour of a cmd.exe console and is slightly annoying.
Ready to be reviewed & merged.