Fixes for OSX hotkey defaults #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligfx
approved these changes
Aug 21, 2017
|
We enforce our coding style clang-format. It is sometimes a bit stupid, but it is a way to get rid of this kind of discussion. But bad luck here, it requires you to reformat your lines. Just checkout the details of the failed "lint" build. Same for you other PR. |
|
Fixed this one, will fix the other as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been plagued with hotkey issues for some time now on Dolphin on OSX, which I have found stem from an issue in the keyboard.mm files for both OSX and Quartz inputs, where the keys are specifically labelled in Dolphin's InputCommon. This compounded onto the hotkey manager meant that the default setting was looking for keys that it could never receive.
I'm guessing when Quartz was implemented, it just copied a lot of things from the standard OSX Keyboard implementation, which is why they both have the same issue.
I double checked this against both Ubuntu 16.04.3 LTS and Windows 10, and the defaults still behave the same.